search

zitmen / thunderstorm

ThunderSTORM: a comprehensive ImageJ plugin for SMLM data analysis and super-resolution imaging
http://zitmen.github.io/thunderstorm/
GNU General Public License v3.0
91 stars 42 forks source link

Potential issue with wavelet filter implementation #56

Open bhache opened 6 years ago

bhache commented 6 years ago

Hi, I was wondering if there was a mistake in the code for wavelet filter at the following link https://github.com/zitmen/thunderstorm/blob/master/src/main/java/cz/cuni/lf1/lge/ThunderSTORM/filters/CompoundWaveletFilter.java

line 57 and 58 result_F1 = subtract(input, GrayScaleImageImpl.convertToFloatProcessor(V1)); result_F2 = subtract(input, GrayScaleImageImpl.convertToFloatProcessor(V2));

I think that according to Izeddin et. al.

F2 = V1 - V2

but there seems to be an error with line 58 where the current implementation would mean

F2 = V0 -V2.

Could you please verify, thank you.

Regards Bhaskar