Cleanup / Scijava Travisify / Auto update site upload

zitmen / thunderstorm

ThunderSTORM: a comprehensive ImageJ plugin for SMLM data analysis and super-resolution imaging

http://zitmen.github.io/thunderstorm/

GNU General Public License v3.0

91 stars 42 forks source link

Cleanup / Scijava Travisify / Auto update site upload #64

Closed hadim closed 4 years ago

hadim commented 5 years ago

This is a work in progress, not good to be merged.

hadim commented 5 years ago

@zitmen @imagejan @ctrueden

Here is a revamped pom.xml with pom-scijava as a parent. I also had to disable some tests related to X11 so Travis can run them.

I have also added the script to auto-upload new release to update site: https://raw.githubusercontent.com/fiji/fiji/master/bin/upload-update-site.sh. It needs configuration on the Travis side before enabling it.

@zitmen If you don't want or don't have time to review this, maybe we should consider forking this repo to the fiji organization.

Happy to hear your comments.

hadim commented 5 years ago

At the moment Travis fails because:

Some Javadoc error related to mathjax.
It seems like it complains because Kotlin is missing. Need more investigations.

The build log is here: https://travis-ci.org/zitmen/thunderstorm/builds/425020697

hadim commented 5 years ago

Here is the code I use to compile Kotlin on my machine with Eclipse: https://github.com/zitmen/thunderstorm/blob/876d254de9a0af4df4d4969e5ed33ddb0c63d285/pom.xml#L242

I don't know if it's possible/worth adding this to pom-scijava.

While this code works well on my machine, it doesn't on Travis.

ctrueden commented 5 years ago

@hadim There is already code in pom-scijava-base to support Kotlin. You just have to put the .kt files into src/(main|test)/kotlin instead of src/(main|test)/java. Please give it a try and let me know whether it works for you.

@zitmen Any comments? Would be great to move this forward. Please let us know either way what you think.