zitmen / thunderstorm

ThunderSTORM: a comprehensive ImageJ plugin for SMLM data analysis and super-resolution imaging
http://zitmen.github.io/thunderstorm/
GNU General Public License v3.0
92 stars 42 forks source link

Use fiji-lib as a *dependency* #9

Open zitmen opened 9 years ago

zitmen commented 9 years ago
Fiji-lib's GenericDialogPlus class is used by a method that is prone to cause problems:
the source of a specific version was copied and dropped into place.

This will eventually result in diverging histories, and worse: because the package
name was not changed, plugins requiring newer versions of said class will break because
ThunderStorm shadows the appropriate class version.

The Fiji project stands for collaborative, collegial development of source code. We
would therefore be delighted to develop our code in cooperative communication with
you (as opposed to the current state, where I had to stumble over the source code to
find out that our code was used).

So let's use fiji-lib as a dependency instead of copying the code into the Thunder-Storm
source code. While at it, we would be excited to help you convert it from a NetBeans-only
project into a Maven project (that can be developed easily with NetBeans but also with
Eclipse and other development environment), and also to offer your plugin via a convenient
update site.

Original issue reported on code.google.com by johannes.schindelin on 2014-04-27 21:51:22

zitmen commented 9 years ago
GenericDialogPlus is a remainder from the very beginning of developement of ThunderSTORM.
Since then we have developed our own MacroAwareUI (https://bitbucket.org/pepa_borkovec/macroawareui/)
and slowly migrated all dialogs to the this new library.

Since we don't use Fiji in our lab, we haven't noticed of any malfunction. I am sorry
if it caused any difficulties. The dependency on GenericDialogPlus was completely dropped
in the latest daily build which is available through the ThunderSTORM's built-in updater.

We are interested in collaboration with Fiji project, therefore, if you have any further
remarks, please let us know.

Original issue reported on code.google.com by zitmen on 2014-04-28 09:22:00

zitmen commented 9 years ago
(No text was entered with this change)

Original issue reported on code.google.com by zitmen on 2014-05-12 19:09:30

zitmen commented 9 years ago
The project has been converted to Maven. However, we still need to resolve 2 dependencies
and decide how to keep track of new versions (daily/stable and ImageJ/Fiji builds).

Original issue reported on code.google.com by zitmen on 2014-05-12 19:12:06