search

ziutek / dvb

DVB/MPEG-TS library (pure Go)
BSD 3-Clause "New" or "Revised" License
99 stars 17 forks source link

OMG, please revert back to ba2b496e072ba36f77d4550ecd7c89fb06735d4b #13

Closed marc-ostrow closed 3 years ago

marc-ostrow commented 3 years ago

Michal, you were so kind to respond so quickly to my PR. Thank you, but OMG, I'm so sorry! I just reread my comments on the PR

Typical Headers look as follows.

[000001bd002c81800525339fe61f305f31385f323134323837373434315f32355f313631363930323031393339393131380a]
[000001bd002c81800525339ffd95305f31395f323134323838343136335f32355f313631363930323031393431383338360a]
[000001bd002c8180052533a1150b305f32305f323134323839323533315f32355f313631363930323031393435393937350a]

stream_id is 0xbd, Flags are present, PTS is present

"Flags are present" !!!!

I honestly don't know what I was seeing, HasFlags() is clearly returning a false value when any of the listed stream IDs is present. Stream ID 0xbd, has flags, at least in the streams we are receiving!

I sent two emails, but either both were to bogus addresses, or you've been too busy to see. So not as quietly as it might have been if you had noticed my emails, would you please, roll back PR #12.

Thank you!

ziutek commented 3 years ago

Done. Thanks!

ziutek commented 3 years ago

I've just reset to ba2b496e072ba36f77d4550ecd7c89fb06735d4b. The history was changed but it isn't very popular repository so I think it shouldn't be a big problem.