search

zivester / node-quickthumb

On the fly, thumbnail creation middleware for express.
MIT License
85 stars 24 forks source link

Added -auto-orient options #15

Closed AamuLumi closed 2 years ago

AamuLumi commented 9 years ago

-auto-orient option in imagemagick avoid to loose EXIF information in image, and keep portrait picture as portrait picture. Resolved #4. (more info : http://www.imagemagick.org/discourse-server/viewtopic.php?t=12998)

dogusev commented 9 years ago

Hi! When this will be merged?

AamuLumi commented 9 years ago

I don't know. There's some pull requests waiting on this projects. Perhaps this project needs an updated fork with all updates.

dogusev commented 8 years ago

By the way, this fix is not stable. I tried, and images didn't saved at all. I'll try to provide more info, a bit later

zivester commented 8 years ago

@AamuLumi or @dogusev could you provide an example image for which this does/doesn't work? I appreciate the PR, just would like to verify before its inclusion.

dogusev commented 8 years ago

@AamuLumi @zivester here is an error [Error: Command failed: convert.im6: unrecognized option `-auto_orient' @ error/convert.c/ConvertImageCommand/714. ] timedOut: false, killed: false, code: 1, signal: null

and this is the image: 1446828115787

AamuLumi commented 8 years ago

I found the (so stupid) error : I wrote "-auto_orient" instead of "-auto-orient". @dogusev can you check if all is good for you ? I personally test on landscape and portrait picture, and no problem for me.

dogusev commented 8 years ago

@AamuLumi
Seem to be ok now, different orientations and image formats converted correctly! Thanks!