search

zivid / zivid-python-samples

Python code samples for Zivid
https://zivid.com
BSD 3-Clause "New" or "Revised" License
37 stars 14 forks source link

Upgrade CI python version to 3.8 #50

Closed trym-b closed 4 weeks ago

trym-b commented 4 years ago

Unless the targeted python version is exactly the default python version for ubuntu 18.04. If we are targeting a specific python version it should be made explicit.

knatten commented 4 years ago

I think we should rather use 3.5, which is the minimum required version for zivid-python. We need to be sure that the samples are compatible with the same version as zivid-python.

Ideally, use a matrix like in their azure-pipelines.yml, and test on several versions.

SatjaSivcev commented 3 years ago

I am planning to modify CI so to use U16 U18 and U20 for setup.sh test and U18 for lint.sh test. I suggest we then use whatever python versions are the default for Ubuntu installations? That would be 3.5 for U16, 3.6 for U18 and 3.8 for U20. What do you think?

trym-b commented 3 years ago

Sounds good, but just to make it clear that means we will require at minmum python 3.5 to run the samples. Python 3.6 and 3.8 should be able to run 3.5 code just fine.

Also, I would recommend running the linter on ubuntu 20.04 instead of 18.04 if you are updating the linters as well.

nedrebo commented 3 years ago

This is what we do in the official wrapper:

The main goal is to have one dimension per minor Python version per Win/Linux. Then we assume that the patch version of Python does not matter.

nedrebo commented 3 years ago

As you can see we are missing 3.9 on Linux, but that is tracked by https://github.com/zivid/zivid-python/issues/107.

SatjaSivcev commented 3 years ago

Sounds good, but just to make it clear that means we will require at minmum python 3.5 to run the samples. Python 3.6 and 3.8 should be able to run 3.5 code just fine.

Also, I would recommend running the linter on ubuntu 20.04 instead of 18.04 if you are updating the linters as well.

Updating linter to run on 20.04 (3.8) is blocked by https://github.com/zivid/zivid-python-samples/issues/95