search

zivid / zivid-python-samples

Python code samples for Zivid
https://zivid.com
BSD 3-Clause "New" or "Revised" License
39 stars 16 forks source link

Zivid and vtk visualizer #7

Closed SatjaSivcev closed 5 years ago

SatjaSivcev commented 5 years ago

Can you please review the code of this sample program? I will make a mini-tutorial on how to install and run the vtk visualizer for this sample on the knowledge base.

nedrebo commented 5 years ago

This PR looks like it includes lots of the changes from #6. I would make this a PR draft or not make the PR at all until #6 is merged. Else we risk that people waste time reviewing the same changes twice, or if they notice it like I did, then they will have a hard time untangling what changes to review.

SatjaSivcev commented 5 years ago

I've noticed that @nedrebo but I didn't know how to deal with it.

nedrebo commented 5 years ago

I've noticed that @nedrebo but I didn't know how to deal with it.

I think that when you created this branch you should have branched from master and not from the branch in #6.