search

zivid / zivid-python-samples

Python code samples for Zivid
https://zivid.com
BSD 3-Clause "New" or "Revised" License
39 stars 16 forks source link

Enable pylint in CI #8

Closed nedrebo closed 5 years ago

nedrebo commented 5 years ago

requirements.txt was left out of date, but CI did not detect it.

Hopefully pylint would have detected that, and anyway it would be nice to have pylint enabled in this repository.

nedrebo commented 5 years ago

FYI: @trym-b

Just an idea. Maybe you can help with that, but @SatjaSivcev should also be i the loop.

trym-b commented 5 years ago

It is easy to add, but I don't want to make the CI here so complicated that the regular users of this repo does not understand what is going on.

SatjaSivcev commented 5 years ago

Maybe we can try and see how it goes?

nedrebo commented 5 years ago

It is easy to add, but I don't want to make the CI here so complicated that the regular users of this repo does not understand what is going on.

Then they need to learn. Better that than broken repository for end users. #6 breaks master, and master in cpp-extra-samples is already broken (https://github.com/zivid/cpp-extra-samples/issues/1#issuecomment-511924511). Better that we struggle with getting code merged than that customers struggle using our code. We aim for high quality and simplicity, CI is the simplest way I know of to achieve that.

trym-b commented 5 years ago

This issue has been fixed