zivid / zivid-python

Official Python package for Zivid 3D cameras
BSD 3-Clause "New" or "Revised" License
40 stars 14 forks source link

MISC: Add support for frame2d.image_rgba() #217

Closed torbsorb closed 1 year ago

torbsorb commented 1 year ago

We have samples which utilize the new feature where you can directly copy in BGR format. To keep samples aligned we add the missing feature here.

test_release.py does not require explicit testing with image_bgra().

pytest has been run with and without the marker physical_camera. The test was run on Windows, and the samples tests failed because of something unrelated (not root caused, but points towards pytest.helpers.run_sample). All samples were tested directly without pytest. They all pass.

Note! We should also consider adding BGR for pointCloud.

MISC

eskaur commented 1 year ago

Regarding the commit-message:

eskaur commented 1 year ago

Looks good. Feel free to rebase on master whenever.