Closed eskaur closed 9 months ago
We noticed that unit-tests were failing when run with SDK 2.11. It turns out that we were not tearing down objects in the right order, and SDK 2.11 is less tolerance to such things.
Maybe mention this in the SKD changelog @apartridge? Just a reminder about the lifetime requirements for Zivid::Applicaton
. Probably some customer code will hit the same and then it is nice if it is already addressed in the Changelog.
We noticed that unit-tests were failing when run with SDK 2.11. It turns out that we were not tearing down objects in the right order, and SDK 2.11 is less tolerance to such things.
Maybe mention this in the SKD changelog @apartridge? Just a reminder about the lifetime requirements for
Zivid::Applicaton
. Probably some customer code will hit the same and then it is nice if it is already addressed in the Changelog.
Honestly the docstring for Application is outrageously short
We want to first understand why there is a regression in 2.11 compared to 2.10. We will investigate this.
Actually the docstring in the header is good. But I can't find the same info on the doxygen page.
We noticed that unit-tests were failing when run with SDK 2.11. It turns out that we were not tearing down objects in the right order, and SDK 2.11 is less tolerance to such things.
This commit does two things to fix the unit-tests: