Change iris valeus to 14,21,35 in capture_hdr.py

zivid / zivid-python

Official Python package for Zivid 3D cameras

BSD 3-Clause "New" or "Revised" License

40 stars 14 forks source link

Change iris valeus to 14,21,35 in capture_hdr.py #56

Closed SatjaSivcev closed 4 years ago

SatjaSivcev commented 4 years ago

https://github.com/zivid/zivid-python/blob/0c13385e884cb7a763e6056f74b00760b5f78b20/samples/sample_capture_hdr.py#L10-L12

Currently, iris values in use are 20, 30, 60. For most common dynamic range coverage we should use 14, 21, 35. This is in line with Zivid Academy: https://zivid.atlassian.net/wiki/spaces/ZividKB/pages/99844206/Getting+the+right+exposure+for+good+point+clouds

nedrebo commented 4 years ago

Feel free to open PRs instead of issues for trivial changes. I think that will be more efficient for both parts. Issues like this are unlikely to get top priority by us and it will usually take long time before addressed.

SatjaSivcev commented 4 years ago

@nedrebo I don't have permision to create a branch in this repo. Can I get it?

nedrebo commented 4 years ago

I added your team.

(When you don't have access to create branches in a public repository you can still always make a fork and a PR back into the main repository.)