search

zivid / zivid-ros

Official ROS driver for Zivid 3D cameras
BSD 3-Clause "New" or "Revised" License
60 stars 45 forks source link

Add command for applying settings from YML file #33

Closed runenordmo closed 2 years ago

nedrebo commented 4 years ago

Can you be more verbose? I am not sure what this is about.

runenordmo commented 4 years ago

I think it's quite involved providing settings for HDR in the ros sample.

We can add something in line with the cpp sample capturing with samples from YML, or a command that let's you capture with settings from YML in ros.

Will probably require that #31 has been done first. This was part of a discussion in https://github.com/zivid/zivid-ros/pull/32#discussion_r469183151.

apartridge commented 4 years ago

I agree that this should be improved. In SDK 2 we contain the whole HDR setting in one file, so we could add a command to load settings from a file, maybe also a launch parameter to initialize the settings.

apartridge commented 3 years ago

Another reason to do this issue is that it can be used to safely load/store settings across SDK versions. Using ROS' system for persisting configs/settings will not be safe because it won't handle settings being moved/renamed etc.