zivid / zivid-ros

Official ROS driver for Zivid 3D cameras
BSD 3-Clause "New" or "Revised" License
55 stars 43 forks source link

Fix broken CI status badge #80

Closed apartridge closed 1 year ago

apartridge commented 1 year ago

There was a change in shields.io API, see issue https://github.com/badges/shields/issues/8671. This change makes the build badge work again.

knatten commented 1 year ago

Seems to work fine!

I'm not very experienced with this, but does anyone know why we use shields.io in the first place? On one of my side projects, I use GitHub directly like this:

![CI](https://github.com/knatten/DumbLang/actions/workflows/ci.yml/badge.svg)

It renders like this:

Screenshot 2023-01-09 at 17 39 42

This is documented at https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge.

apartridge commented 1 year ago

Maybe @trym-b remembers if there is a good reason to use shields.io? Else we can swap it out with the official one.

knatten commented 1 year ago

Could be that GitHub didn't support this when we started using it or something.

trym-b commented 1 year ago

Maybe @trym-b remembers if there is a good reason to use shields.io? Else we can swap it out with the official one.

I think we should use the official ones. I do not recall why we exactly ended up selecting shields.io instead of something else.

nedrebo commented 1 year ago

Maybe @trym-b remembers if there is a good reason to use shields.io? Else we can swap it out with the official one.

I think we should use the official ones. I do not recall why we exactly ended up selecting shields.io instead of something else.

Because if you have multiple badges from various vendors like we do in Python, then it looks messy and inconsistent unless you use a proxy provider that gives a uniform look.

nedrebo commented 1 year ago

Seems we need the same fix in zivid-python.

eskaur commented 1 year ago

Merge this @apartridge ?

nedrebo commented 1 year ago

Seems we need the same fix in zivid-python.

Any takers @eskaur :D