search

zivid / zivid-ros

Official ROS driver for Zivid 3D cameras
BSD 3-Clause "New" or "Revised" License
55 stars 43 forks source link

Implement support for pointxyz and range leaves #81

Closed knzivid closed 1 year ago

knzivid commented 1 year ago

RFNR

apartridge commented 1 year ago

The code is looking good, I tested it and it works as expected. I just added a few comments on the test. If you can fix those I will approve.

I think we can do the bump to 2.9 in a separate PR, as we also want to update README etc.

knzivid commented 1 year ago

Unless you have any other feedback, can you approve the PR?

apartridge commented 1 year ago

https://github.com/zivid/zivid-ros/pull/81#discussion_r1157007718

knzivid commented 1 year ago

Remember to unresolve the thread if you comment on them :)

knzivid commented 1 year ago

RFNR

knzivid commented 1 year ago

PS: The CI looks a bit dead, probably because you are making this PR from your own fork?

Can you allow CI for me as an external contributor then?