search

zivid / zivid-ros

Official ROS driver for Zivid 3D cameras
BSD 3-Clause "New" or "Revised" License
55 stars 43 forks source link

Fix wrong port in README.md #85

Closed iosb-ina-mr closed 10 months ago

iosb-ina-mr commented 1 year ago

In the readme it says that the camera has to be connected to a USB3 port but the camera supports ethernet only by default.

apartridge commented 1 year ago

Hi @iosb-ina-mr, thanks for your PR. The Zivid One+ cameras use USB3, while the Zivid Two and Two+ cameras use Ethernet. So this text was indeed incorrect, we forgot to update this part after our release of the Zivid Two camera. Maybe you can change your commit to "ethernet or USB3 port"?

iosb-ina-mr commented 1 year ago

Hi @iosb-ina-mr, thanks for your PR. The Zivid One+ cameras use USB3, while the Zivid Two and Two+ cameras use Ethernet. So this text was indeed incorrect, we forgot to update this part after our release of the Zivid Two camera. Maybe you can change your commit to "ethernet or USB3 port"?

For sure, I was not aware of that. I have adjusted the PR.

apartridge commented 10 months ago

@iosb-ina-mr I did a rebase of the PR in order to re-trigger the tests since they failed due to a flaky test.

iosb-ina-mr commented 10 months ago

@apartridge Great! Thank you for effort.