Fix download (folder check/resume/unnecessary HTTP requests)

zixaphir / Stable-Diffusion-Webui-Civitai-Helper

Stable Diffusion Webui Extension for Civitai, to manage your model much more easily.

175 stars 24 forks source link

Fix download (folder check/resume/unnecessary HTTP requests) #42

Closed Milly closed 7 months ago

Milly commented 7 months ago

Fix problem

Download folder existence check may fail.
Unable to resume download.

Improve

There were always two HTTP requests when downloading, now it's one time if it doesn't resume.
Refactoring.
Fix typing.

Milly commented 7 months ago

If there are too many differences, I will split the PR. Please point it out.

zixaphir commented 7 months ago

Thank you for this. This lets me see some areas where I was sloppy or less than well informed. Things like using the wrong file write tokens or using "or" where I should have used "and" are embarrassing to see, but informal of issues with my development process. I was not aware of yield from and I am reading into it so that I can incorporate it where it would make more sense.