search

zixaphir / appchan-x

The most comprehensive, feature filled 4chan userscript.
http://zixaphir.github.io/appchan-x
Other
133 stars 61 forks source link

Post form not clearing. #393

Closed Catmato closed 11 years ago

Catmato commented 11 years ago

After I post in a thread, the QR form doesn't clear. Comment, email, and file remain. Not sure about name, captcha, or subject as I typically don't use those. The same thing was happening with seaweed's 4chanX/Oneechan, but not with 4chanX alone. I use Greasemonkey with FF22 and have tried disabling all other add-ons and scripts.

Quenser commented 11 years ago

Same here, also whenever that happens my posts are't marked as mine, only if quoted by others. Chrome 28.0.1500.72 m.

MaddoScientisto commented 11 years ago

It's happening to me on firefox aurora too but only when switching tab right after hitting the submit button, not happening normally otherwise.

zixaphir commented 11 years ago

Not happening here. Looking into it. It could be a 4chan issue if it's only happening sometimes (as Appchan must receive a confirmation from 4chan to know whether or not your post has been posted). This would also affect post marking, as this is also where we get the post number from.

Quenser commented 11 years ago

It started happening with 2.2.0 for me, if that's of any help. Also, it's not just happening sometimes but more like 90% of the time.

MaddoScientisto commented 11 years ago

It happened on three different computers of mine, all three running aurora. Also when it happens if I post something else on another tab the other faulty tabs all try submitting the post and give captcha error because of course there are no cached captchas.

Oh also it happens on i haven of ace's but without the tab switching, I'm not sure if that's what's causing it On Jul 31, 2013 9:44 PM, "Zixaphir" notifications@github.com wrote:

Not happening here. Looking into it. It could be a 4chan issue if it's only happening sometimes (as Appchan must receive a confirmation from 4chan to know whether or not your post has been posted). This would also affect post marking, as this is also where we get the post number from.

— Reply to this email directly or view it on GitHubhttps://github.com/zixaphir/appchan-x/issues/393#issuecomment-21889852 .

Catmato commented 11 years ago

It happens 100% of the time for me.

zixaphir commented 11 years ago

Should be fixed.

Charles-Barkleton commented 11 years ago

Oh good, I was using Mayhem in the meantime. I much prefer yours for customization and personality. Although he has stability done like it's his bitch.

I notice you both have the same wording for a lot of the things within in both apps, instead of sharing code why haven't everyone just worked on one extension together?

Quenser commented 11 years ago

QR clears now as it should but post marking is still broken.

Charles-Barkleton commented 11 years ago

Oh, files still sticking around after post.

Quenser commented 11 years ago

files still sticking around after post

Just tried it, same result here.

zixaphir commented 11 years ago

I notice you both have the same wording for a lot of the things within in both apps, instead of sharing code why haven't everyone just worked on one extension together?

It is outside of my control. https://github.com/MayhemYDG/4chan-x/issues/1083

Oh, files still sticking around after post. QR clears now as it should but post marking is still broken.

Looking into these

Charles-Barkleton commented 11 years ago

You guys remind me of moot(mayhem), snacks(Seaweed), shii(you except you don't drop all your projects) and shut(aero).

Oh well, drama is drama. Glad you answered it, hope you can fix this problem (or just take it from mayhem, whatever works).

seaweedchan commented 11 years ago

Right now both of us are fully willing to work with @ihavenoface and @MayhemYDG, but neither of them want to, a mindset that in my opinion has just resulted in this huge fragmentation of 4chan X forks, and situations like https://github.com/MayhemYDG/4chan-x/pull/1164 where they're working on features we've already done. So you can feel free to try to argue on our behalf, but I can't even get them to respond to simple emails anymore.

Charles-Barkleton commented 11 years ago

I think they might want to work their own code through mayhem's script. Which is a damn shame since you guys have a shitton of useful features (an all-in-one of the others, like he said) while they have stability and ease (There's only been a few problems and everything works right away and feels smooth).

I could only imagine the scene of KJJ and MVB dig their own grave with the minimal "official" built-in script in hand.

Well no point in the constant worry of inconsistency. They'll come around. But if they don't, I suggest a different method in order to be friends and play nice. http://www.youtube.com/watch?v=dYBjVTMUQY0

Ganbatte ballers.

seaweedchan commented 11 years ago

Was about to say that I'm not aware of our fork not being stable or easy, but then I realized that this is the Appchan tracker lol

zixaphir commented 11 years ago

You guys remind me of moot(mayhem), snacks(Seaweed), shii(you except you don't drop all your projects) and shut(aero).

But if they don't, I suggest a different method in order to be friends and play nice.

Truly, I would love to work with @MayhemYDG and @ihavenoface. This is not a decision that is within my realms of control though. I don't want to sound like I'm blaming them, because it's not something I want to fault them for, but at this point there is nothing I can really do to help the process of a unified script. Appchan was born out of differences in how I feel things should be done versus how they felt things should be, so I can't fault them for wanting to continue to do things their way. I am, however, saddened that the boundaries between all of the scripts has prevented them from absorbing any improvements done at all on my end. That doesn't feel right to me and I can throw fits about it all day, but sadly, when I'm described as a parasite by one party and completely overlooked because of it, I can't help but be baffled.

But my attempts to reach out and patch up the differences between Mayhem and I, especially, have no returns to show for. Retrospectively speaking, I will admit that I have said some harsh things that fuel the fire, but I am willing to apologize for my faults, and harbor no ill will. I do not wish to stir up this pot again, though, so I would prefer you not argue on my behalf. Mayhem, especially, has made it clear that he is cemented in his beliefs, and I feel it is best to honor that and maintain a respect for what he has accomplished, rather than pester him time and time again over something he's already stated he does not want to reconsider.

Yttrium-tYcLief commented 11 years ago

tl;dr two specific developers need to grow up

ihavenoface commented 11 years ago

I just prefer not getting stabbed in the back. The first year I had a positive attitude towards the whole thing, but as things stand now I can't see a future for it. I can't even say "I'm sorry" at this point.

seaweedchan commented 11 years ago

@noface I don't think you have anything to apologize for, you've stayed plenty mature. Probably more so than zixaphir or myself. I would at the very least like to have communication opened up though for shared bug fixes, oneechan support, etc.

Catmato commented 11 years ago

Should be fixed. Unless I'm doing something wrong, it doesn't work using the latest build.

Quenser commented 11 years ago

That's because it isn't fixed yet entirely.

Catmato commented 11 years ago

That's because it isn't fixed yet entirely.

Oh, I assumed "Should be fixed." and closing the issue meant it was fixed and the issue was closed.

My mistake.

zixaphir commented 11 years ago

Oh, I forgot to reopen this? My bad.

Quenser commented 11 years ago

I've switched PC's now and the same issue still persists. This is with Chrome and auto-imported settings from my google account. Might help narrow it down, maybe.

zixaphir commented 11 years ago

Alright, haven't had any luck reproducing this. If someone could give me their console log after this error occurs, that would be very helpful. (CTRL-SHIFT-J on Chrome, CTRL-SHIFT-K on Firefox)

Quenser commented 11 years ago

Which part of it do you want? http://puu.sh/44P2r.png

Catmato commented 11 years ago

Did not occur when not using pass. Are you testing without a pass?

On Sun, Aug 18, 2013 at 10:49 AM, Quenser notifications@github.com wrote:

Which part of it do you want? http://puu.sh/44P2r.png

— Reply to this email directly or view it on GitHubhttps://github.com/zixaphir/appchan-x/issues/393#issuecomment-22833087 .

Quenser commented 11 years ago

I don't have a pass. My extensions for 4chan are pretty vanilla too. 4chan Media Player and Exlinks.

Catmato commented 11 years ago

Odd. I tried it once in a private window and it worked so I just tried signing out in a regular session and the error didn't occur. Upon signing back in, it starts to happen again. Web Console: http://pastebin.com/U6LTJBFg

zixaphir commented 11 years ago

You got a 4chan Pass?

Catmato commented 11 years ago

Yeah.

zixaphir commented 11 years ago

shud be fxxxd

Quenser commented 11 years ago

Nope.

Catmato commented 11 years ago

It's working for me. TYVM Zix.

zixaphir commented 11 years ago

@Quenser: Yeah, but your using TamperMonkey and I do not provide support for TamperMonkey. Unless of course, you're not using TamperMonkey for Appchan, in which case I have to find out why your copy is saying "undefined is not a function".

Quenser commented 11 years ago

I'm not using Tapermonkey for appchan and I wouldn't be pestering you about this unless I was sure this was something to do with appchan, I tried disabling all other extensions and the problem still persist. This is with Tapermonkey disabled: http://puu.sh/45HHo.png and this is with all extensions disabled be they 4chan related or no: http://puu.sh/45HNk.jpg

Those two test pots are mine and as you can see they both have not been marked down. This is what happens when I reply to my own post: http://puu.sh/45HRe.jpg As you can see it's marked down now, as would be any other posts replying to it. Again this was still with all of my extensions disabled save for appchan x.

Catmato commented 11 years ago

This bug is about the post forms not clearing.

Quenser commented 11 years ago

I thought we were talking about issues with markdown too. Post form is clearing correctly now.

seaweedchan commented 11 years ago

Then maybe you should say more than "Nope."

Quenser commented 11 years ago

I apologize. That was indeed stupid of me and I should have specified further.