search

zixin448 / pe

0 stars 0 forks source link

Invalid year accepted #8

Open zixin448 opened 2 years ago

zixin448 commented 2 years ago

Input : add o/event m/cs3223 ke/2 dt/1000-01-01 23:00 Expected: invalid year input Actual: accepted

Screenshot 2022-04-16 at 2.57.29 PM.png

soc-pe-bot commented 2 years ago

Team's Response

As mentioned in the module website,

Screenshot 2022-04-17 at 6.12.50 PM.png

That means that extreme user behaviour where the user tries to deliberately type in nonsensical values are not considered bugs. A user entering a year that is 4 digits, but so obviously an invalid year, like a year thats all the way in the last millennium, thus falls under this category, as there is simply no way a user can enter such a year by accident. Meanwhile for inputs that could be accidentally typed in, such as 20222 (extra digit), our command parser would detect it and inform the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The year input value should definitely be checked as there is a chance that the user just typed 1022 and enter accidentally since they are fast typers! I disagree with the team's response that ' there is simply no way a user can enter such a year by accident ' to explain the lack of check for the year input.