zixpo / candybar

Dashboard for Android Icon Packs. Supported by the community.
Apache License 2.0
299 stars 54 forks source link

Launcher updates #132

Closed Donnnno closed 1 year ago

Donnnno commented 1 year ago

Also got inspired to use @moertel's code and apply it to some other launchers

moertel commented 1 year ago

Really cool! 🚀 Thanks so much for taking care of additional launchers. :) I'm seeing an error in the build logs:

/home/runner/work/candybar/candybar/library/src/main/java/candybar/lib/helpers/LauncherHelper.java:485: error: an enum switch case label must be the unqualified name of an enumeration constant
            case POSIDON:
                 ^
/home/runner/work/candybar/candybar/library/src/main/java/candybar/lib/helpers/LauncherHelper.java:569: error: an enum switch case label must be the unqualified name of an enumeration constant
            case NEO:
                 ^

You deleted Posidon and Neo from the list of enums but not from the switch/case statement.

Donnnno commented 1 year ago

Oops, thanks haha

Donnnno commented 1 year ago

Also, I was talking about the dev of Kvaesitso about direct applying methods here https://github.com/MM2-0/Kvaesitso/issues/395#issuecomment-1551131512 And they were talking about some form of an open standard for this, might be interesting, but my knowledge is too small of this 😅