search

zixpo / candybar

Dashboard for Android Icon Packs. Supported by the community.
Apache License 2.0
288 stars 53 forks source link

[Question](How) to handle unsupported icons #175

Closed MiepHD closed 7 months ago

MiepHD commented 7 months ago

How can I configure how icons that aren't supported from the iconpack should look like? In the launcher I use the unsupported icons get smaller which doesn't match the supported icons. WhatsApp Bild 2024-02-11 um 09 05 12_83251ab4 WhatsApp Bild 2024-02-11 um 09 05 12_5bc1e2e4 In Kiss Launcher the icons turn completely white https://github.com/MiepHD/cuscon/issues/18

jm355 commented 7 months ago

One difference I notice between cuscon and arcticons is that arcticons does not have an appmap.xml or theme_resources.xml. Maybe cuscon doesn't need those either?

Donnnno commented 7 months ago

I've never had any complaints about the appmap and theme resources missing.

But then again, idk what they do

kshitijdeota commented 7 months ago

@MiepHD Use <scale factor="x.xx" /> (0.01 ~ 1.00) given in "appfilter.xml", not all launchers respect the icon size settings though.

@Donnnno appmap.xml was provided for launchers like "arrow launcher", "yahoo launcher" and some others that no longer exist. I bet it was abandoned because the xml does not list package names with app activities but just the package names which isn't very helpful today.

_theme_resources.xml_ is for "LG Home", LG phones and their stock launcher used to be really popular back then. I do have enough LG users even today and few launchers still take advantage of this file. It's good to have it in your icon pack.

appfilter.xml has been widely used by most launchers since Nova/ADW/Apex days so it has become an unofficial standard these days for every new launcher.

All the three xml files can be turned on/off form CandyBar.java. App won't generate turned off xml files during icon request. Read the onInit() settings here CandyBar.java

Turned off xml files can also be cleaned up (deleted from the app).

Donnnno commented 7 months ago

Thanks for the explanation @kshitijdeota !

MiepHD commented 7 months ago

Thanks, the unsupported icons will now display in the right size. Only question remaining why do the unsupported icons turn white in Kiss Launcher?

kshitijdeota commented 7 months ago

Remove iconback, iconmask and iconupon references in your appfilter.xml. That should possibly fix the issue.

MiepHD commented 7 months ago

Thanks 😅 Works perfect