zixpo / candybar

Dashboard for Android Icon Packs. Supported by the community.
Apache License 2.0
299 stars 54 forks source link

Icon search bug #84

Closed randomvector closed 1 year ago

randomvector commented 2 years ago

This has been tested and confirmed on Candybar v3.13.3 and has been reproduced on v3.14.2 by myself and another user in the Telegram group. I've linked a video clip showing the bug using the Candybar Demo.

https://user-images.githubusercontent.com/27604724/170887324-3c7cc59c-99be-478d-b4e1-44d743497671.mp4

sarsamurmu commented 2 years ago

It's been there for a long time. I was not able to solve it. Maybe someone can solve it?

moertel commented 2 years ago

I found a fix. See linked PR. 👀

moertel commented 2 years ago

As to the blank page after using the back button: After lots of trial & error I believe it's a race condition. Performing addToBackStack on the fragment was a nice idea but I'm almost sure it's being garbage-collected before it can be displayed again. I can reproduce the blank page 4 out of 5 times but occasionally I still see it when I use the back button in the menu. Also, I can reproduce this with API 28 as well although it behaves slightly differently.

The only meaningful connection I found was this bug (which is said to be fixed) which describes what we're seeing here (IMHO): https://issuetracker.google.com/issues/139095195