search

ziyang27 / pe

0 stars 0 forks source link

Wrong naming of class in class diagram in DG #5

Open ziyang27 opened 4 months ago

ziyang27 commented 4 months ago

Hello, in the Developer Guide (DG), under implementation, specifically for Add new employee, one of the diagrams mentioned 'VersionedPayBack' which I could not find any reference to it in the DG.

image.png

Upon looking at the code on github, I still can't find any class with that name. Perhaps you can take a look at this? If I happen to miss it I am so sorry

nus-pe-bot commented 4 months ago

Team's Response

Sorry, it seems like there is a typo and the class is named "PayBack". However, it should be very intuitive as "VersionedPayBack" means our version of Payback class.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]