search

ziyi105 / pe

0 stars 0 forks source link

unable to find keyword is case-sensitive #10

Open ziyi105 opened 9 months ago

ziyi105 commented 9 months ago

image.png

a user would expect search to be not case-sensitive

nus-pe-script commented 9 months ago

Team's Response

Thanks for the input! Similar to issue 149, we believe if the keywords do not match, it should not be returning the meal.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

findmeal is case sensitive to the keyword

image.png

It is not reasonable to differ between "pasta" and "Pasta" when searching for a meal. Therefore the keyword search should not be case sensitive instead.

[original: nus-cs2113-AY2324S1/pe-interim#867] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing it out. Indeed the findmeal command is made to be case sensitive. However, it is true that the findmeal command has no reason to be case sensitive and could be improved in future iterations.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]