ziyi22 / pe

0 stars 0 forks source link

Error message doesn't match with actual behavior for /rate #3

Open ziyi22 opened 7 months ago

ziyi22 commented 7 months ago

image.png

The error message specified that the rating must be integer from 1-5.

Actual: When I type /rate ; name : Poochie ; rating : 0, it allowed me to add rating 0.

Result: The error message doesn't match with its actual behavior.

soc-se-bot commented 7 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This is a duplicate issue regarding the error message for rating, where both issues refer to the fact that our accepted range should have been 0 to 5 not 1 to 5.

Furthermore, fixing #3618 and correcting the error message to say 0 to 5 instead, will also fix this issue.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Message doesn't match with UG

In your UG, you specified that the rating should be 0-5: image.png

But, in the message displayed, you specified that the rating should be 1-5.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#4553] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The error message should say 0 and 5 inclusive. However, this is a deviation from expected behaviour and hence, a functionality bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]