ziyili20 / TOAST

Tools for the analysis of heterogeneous tissues
9 stars 3 forks source link

Error "Y should have dimension P (features) by N (samples)!" from fitModel #3

Closed fumi-github closed 4 years ago

fumi-github commented 4 years ago

Hi. In fitModel.R, you write

if (nrow(Y) < ncol(Y)) { stop("Y should have dimension P (features) by N (samples)!") }

In a situation like simulation, nrow(Y) could be small. I guess the test should be

nrow(Design_out$design_matrix) != ncol(Y)

Thanks.

ziyili20 commented 4 years ago

Yes! Thank you for the comment. I identified this issue too. In the new version of the package, I removed this checking step.