search

ziyin-dl / word-embedding-dimensionality-selection

On the Dimensionality of Word Embedding
https://nips.cc/Conferences/2018/Schedule?showEvent=12567
MIT License
329 stars 44 forks source link

code problem #14

Closed SunYanCN closed 5 years ago

SunYanCN commented 5 years ago

In code matrix/signal_matrix.py:

def construct_matrix(self): raise NotImplementedError

Is this correct? Is there any problem with this part of the code?

zi-yin commented 5 years ago

This is expected. The signal matrix class is abstract, and the actual implementations (LSA_matrix, GloVe_matrix, etc.) will be subclasses which actually implement this member function.