search

ziyingli / pe

0 stars 0 forks source link

Activity diagram for schedule #13

Open ziyingli opened 4 years ago

ziyingli commented 4 years ago

Guard clauses should be outside the diamond

Screenshot 2020-04-17 at 3.27.01 PM.png

nus-pe-bot commented 4 years ago

Team's Response

The guard clauses are already outside the diamond, just that there is an additional conditional statement inside the diamond. However, this is accepted UML notation for conditionals, as per the PlantUML documentation here https://plantuml.com/activity-diagram-beta. However, we do acknowledge that the textbook has a slightly different notation.

In addition, this bug is purely cosmetic and will not confuse developers who are reading this diagram. Therefore, we reassigned this issue a severity of very low.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Our Prof states that this is not standard UML notation, as seen here. Furthermore, this was also stated in one of our post-lectures quizzes to be wrong (seen below). Therefore non-standard UML diagram mistakes should be labelled medium or high as stated here by Prof Akshay.

photo_2020-04-23_21-41-49.jpg