ziyingli / pe

0 stars 0 forks source link

Uncaught case in exercise find #3

Open ziyingli opened 4 years ago

ziyingli commented 4 years ago

e/exercise_name in finding exercise can be alphanumeric, according to UG

but keying in exercise find e/01 does not return any response from the Feedback Display (should display 0 exercise listed! to show 0 matches)

Screenshot 2020-04-17 at 2.32.49 PM.png

nus-pe-bot commented 4 years ago

Team's Response

noted on the issue. we will add the relevant exception handling into our code to return a message to the user if the text is invalid. however, since this is an exceptional case, it does not disrupt the main flow of our application till the point where the "product is unusable for most users". we have reassigned this bug a severity of medium.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: I disagree with the severity level and the team's reasoning, given the two reasons below:

  1. The parameter provided is not invalid and this is not an exceptional case, as both the UG and the usage message displayed in the app clearly states that the e/exercise_name can be alphanumeric (attached below). Therefore using find with a numeric parameter should work the same way as using find with an alphabetic parameter. This issue is not an exceptional case.

  2. This makes the app highly unsuable as this find function is present not only in the exercise component, it is present in workout and log components of the overall app. Given that the find function is used in 3 out of the 4 major components and all of the find commands have the same problem, I believe that this makes the app highly unsuable.

UG Requirement:

Screenshot 2020-04-21 at 2.20.43 PM.png

App usage message:

Screenshot 2020-04-21 at 2.21.29 PM.png