ziyingli / pe

0 stars 0 forks source link

Log find unable to work with numeric #9

Open ziyingli opened 4 years ago

ziyingli commented 4 years ago

Log has workout named name 01, should match when finding for 01 but it does not match. Feedback Box not updated

Screenshot 2020-04-17 at 3.02.47 PM.png

nus-pe-bot commented 4 years ago

Team's Response

noted on the issue. we will add the relevant exception handling into our code to return a message to the user if the text is invalid. however, since this is an exceptional case, it does not disrupt the main flow of our application till the point where the "product is unusable for most users". we have reassigned this bug a severity of medium.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: I disagree with the severity level and the team's reasoning, given the two reasons below:

  1. The parameter provided is not invalid and this is not an exceptional case. The UG and the usage message in the app are not even consistent with each other (as seen below) and does not tell me the specifications of e/exercise_name or w/workout_name and there is no feedback message displayed in the app even if I input a numeric parameter. There is no mention that I cannot use numeric characters. Therefore using find with a numeric parameter should work the same way as using find with an alphabetic parameter. This issue is not an exceptional case.

  2. This makes the app highly unsuable as this find function is present not only in the log component, it is present in workout and exercise components of the overall app. Given that the find function is used in 3 out of the 4 major components and all of the find commands have this problem, I believe that this makes the app highly unsuable.

UG Requirement Screenshot 2020-04-21 at 2.51.24 PM.png

App usage message Screenshot 2020-04-21 at 2.51.33 PM.png