search

zjedi / hugo-scroll

Clean, responsive, single-page Hugo website theme.
https://themes.gohugo.io/hugo-scroll/
MIT License
256 stars 187 forks source link

Contact icons are not centered in the footer #171

Closed filippofontana closed 3 months ago

filippofontana commented 3 months ago

The contact icons in the footer are declared as a list of links and, due to <li> css rules, they have a margin left of 20px which makes them not aligned with the rest of the footer's content. This is more visible when you have, for instance, three contact icons.

Example:

list

I have prepared a new commit with the contact icons displayed without the <li> tag and using flex for displaying and aligning stuff (with some padding to emulate the previous style). If this sounds ok, I can submit a pull request.

Example of the updated design:

flex

Let me know what you think!

UPDATE: of course I can replicate exactly the padding between the icons and the other stuff under them and also between the icons themselves.

zjedi commented 3 months ago

looks good! Not sure why it was a list, it could have something to do with accessibility ... or maybe not. I am not sure, maybe @nai888 would know?

nai888 commented 3 months ago

@zjedi Nope, feel free to change it!

filippofontana commented 3 months ago

Ok, thanks for the feedback guys! I'll send a PR soon.

filippofontana commented 3 months ago

Solved with #172.