search

zjes / lxqt-kbdstate

Keyboard indicator, layout switcher
2 stars 0 forks source link

Move lxqt-kbdstate to lxqt-panel's tree #6

Open paulolieuthier opened 9 years ago

paulolieuthier commented 9 years ago

While it's very exciting to see third party plugins, and specially well written and portable plugins like this one, I want to propose moving it to lxqt-panel's tree. lxqt-panel lacks such feature, and it's not a feature we can afford lacking.

Another important reason to move it to the panel's tree is that lxqt-kbdstate might not get distributed to all places lxqt-panel will be. Different distros, and even BSDs systems. @zjes what's your opinion on that?

Of course, you would submit a PR replacing the existing plugin in lxqt-panel, so that your name will go there and you'll get the deserved merit.

zjes commented 9 years ago

As you wish, I use lxqt, i need need this feature, doesn't matter for me that it will as third party plugin or in lxqt tree.

paulolieuthier commented 9 years ago

Now that I see no more bugs, please create the PR.

zjes commented 9 years ago

Hmm... Like new kdbstate plugin or replace kbdindicator plugin? And it needs 2 PR, first for panel, second to lxqt-common (themes). Or like a standalone project?

paulolieuthier commented 9 years ago

Replacing the current plugin. 2 PRs, for lxqt-panel and lxqt-common, just like the other plugins.

zjes commented 9 years ago

Done, without theming, do not need it, using old themes from kbindicator.

paulolieuthier commented 9 years ago

@zjes two small patches are awaiting for you in #233. Please, apply them and squash the commits.