search

zjkmxy / go-ndn

A NDN client library in Go
https://pkg.go.dev/github.com/zjkmxy/go-ndn
Apache License 2.0
8 stars 1 forks source link

"Verification failed" after adding AppParams #3

Open justincpresley opened 1 year ago

justincpresley commented 1 year ago

After playing around with the schema-based examples, I found a situation where verification fails.

Go version: 1.21.1 + 1.20.8 (tested both) Example: Schema-based Single Packet

Changing this line to be the following: result := <-mNode.Call("NeedChan", enc.Wire{prefix.Bytes()}).(chan schema.NeedResult) i.e. adding AppParams to the interest (the prefix name in this case for simplicity).

This results in the attached error. error

I assume the schema needs to be changed to state there is parameters added to the interest? Yet after looking through the codebase including the svs example that also signs the interest, I do not see any option. Am I missing something?

zjkmxy commented 1 year ago

An Interest with AppParam must be signed. However, current NTSchema does not automatically signs the Interest. The SVS example specifies a signer as: https://github.com/zjkmxy/go-ndn/blob/2e42d595c02b3b60ec55893099b885bcbd546101/examples/schema-test/sync/schema.json#L37-L41

justincpresley commented 1 year ago

That makes sense. It's good it doesn't just let me use the Sha256Signer for security reasons. Okay, I suppose Hmac can work for rough testing the functionality of an app. Thank you!