search

zjorz / Public-AD-Scripts

AD Scripts
GNU General Public License v3.0
273 stars 77 forks source link

Some minor issues with Reset KrbTgt Password script #4

Closed paulhey closed 1 year ago

paulhey commented 3 years ago

In the process of auditing this script for use in our environment I found I couple of issues that I've submitted fixes for in #3 One is just using the automatic variable $PWD during password generation, which could lead to some rather bizarre results. The other is just a typo in using a variable in a single-quoted string instead of a double-quoted string.

zjorz commented 2 years ago

Hi, can you please point out which is "The other is just a typo in using a variable in a single-quoted string instead of a double-quoted string."? Thanks

zjorz commented 2 years ago

never mind, found it

zjorz commented 2 years ago

thanks for the feedback. Adding your fixes. Working on processing feedback from different people

zjorz commented 1 year ago

Latest version contains fix to this