search

zjosua / anki-mc

Multiple choice questions for Anki.
https://ankiweb.net/shared/info/1566095810
GNU Affero General Public License v3.0
49 stars 16 forks source link

Add option to restrict number of answers shown #103

Closed 3ter closed 1 year ago

3ter commented 1 year ago

This PR should address the issues kindly requested in https://github.com/zjosua/anki-mc/pull/100#pullrequestreview-1264722077

Fixes #99

PS It depends on #102

zjosua commented 1 year ago

Looks good so far. For cases where only wrong answers are displayed, there should be a "Clear selection" button on the front when the QType is 2 (single choice) and maxQuestionsToShow > 0.

3ter commented 1 year ago

I rebased the branch onto master to make the diff more readable. I remember we had this issue some time ago in a previous PR when I didn't know what to do in the case you have a feature branch depending on another one that has been merged to master in the meantime.

The solution is git rebase --onto master next topic from https://git-scm.com/docs/git-rebase

3ter commented 1 year ago

Looks good so far. For cases where only wrong answers are displayed, there should be a "Clear selection" button on the front when the QType is 2 (single choice) and maxQuestionsToShow > 0.

I understand that this is a problem that needs adressing, otherwise you would be bound to answer incorrectly.

I think it would be more fitting to the nature of single choice to always get the right answer in there with the shown questions. Let's see if I can come up with something.

3ter commented 1 year ago

Now the preview is broken. Let me have a look again.

3ter commented 1 year ago

There's still a bug with the solutions now 😆. Perhaps tomorrow then.

3ter commented 1 year ago

@zjosua Now I consider it ready. I had time to test it with all card types with and without restricting the number of possible choices shown.

zjosua commented 1 year ago

Works fine for me too.