search

zju3dv / NeuralRecon

Code for "NeuralRecon: Real-Time Coherent 3D Reconstruction from Monocular Video", CVPR 2021 oral
https://zju3dv.github.io/neuralrecon/
Apache License 2.0
2.07k stars 299 forks source link

dead code? #5

Closed cdcseacave closed 3 years ago

cdcseacave commented 3 years ago

here you modify the pose, but if I'm not mistaken (I'm a python noob), you finally use the unmodified pose; is this intended? https://github.com/zju3dv/NeuralRecon/blob/f7ae3b82369fc031708bc78f395377a424e1be82/tools/process_arkit_data.py#L87

JiamingSuen commented 3 years ago

The modified pose is unused and it does not affect the reconstruction. Originally we intended to shift the z-axis in the pose to match the ground plane level on ScanNet. We later found out it's actually not necessary. The code has been removed now, thanks for the heads up!

JiamingSuen commented 3 years ago

Feel free to reopen this issue if you have more questions.

JiamingSuen commented 3 years ago

As suggested in #6 and commit eec464fd63fd033cd0e9018842faad8dda6e1f83, it turns out to be necessary to shift the z-axis. Sorry for the confusion.