search

zju3dv / PGSR

[TVCG2024] PGSR: Planar-based Gaussian Splatting for Efficient and High-Fidelity Surface Reconstruction
https://zju3dv.github.io/pgsr/
Other
507 stars 33 forks source link

The code in densify_and_split #50

Closed kimwao closed 1 month ago

kimwao commented 1 month ago

2024-10-16_231604 padded_grads_abs[selected_pts_mask] = 0 should be changed to padded_grads_abs[~selected_pts_mask] = 0.

1030366507 commented 1 month ago

这个有啥影响吗？

GuangyuWang99 commented 1 month ago

I don't think this should be changed. padded_grads_abs is used to compute selected_pts_mask_abs, which is another set of points threshold by 3D scaling and 2D scaling to complement selected_pts_mask (See torch.logical_or in L445). And the logic is that there should be no intersections between selected_pts_mask_abs and selected_pts_mask_abs.

kimwao commented 1 month ago

I don't think this should be changed. padded_grads_abs is used to compute selected_pts_mask_abs, which is another set of points threshold by 3D scaling and 2D scaling to complement selected_pts_mask (See torch.logical_or in L445). And the logic is that there should be no intersections between selected_pts_mask_abs and selected_pts_mask_abs.

Yes, you're right! Thank you