zju3dv / SMAP

[ECCV 2020] SMAP: Single-Shot Multi-Person Absolute 3D Pose Estimation
Apache License 2.0
241 stars 37 forks source link

question abount eval and test code #26

Closed Xuer0313 closed 3 years ago

Xuer0313 commented 3 years ago

https://github.com/zju3dv/SMAP/blob/9fbcbe4ee2cd6f6d6d6a4e5a05a637629cb5b2e1/lib/eval/convert.py#L31 https://github.com/zju3dv/SMAP/blob/9fbcbe4ee2cd6f6d6d6a4e5a05a637629cb5b2e1/exps/stage3_root2/test.py#L34 I have no idea which json file you used for evaluation. According to my understanding, you may use the test result to eval. In other words, the key of dict "result" in test code should be the same as that of eval code. But it seems that they did not follow the same key as the link I list above.

raypine commented 3 years ago

Yeah, the converting code is old and has minor differences with the release code. But it can be easily fixed by replacing 'pred' with 'pred_3d', and 'gt' with 'gt_3d'. Only the rescale and reprojection matter.

raypine commented 3 years ago

If you still have problems after fixing these, we will revise the code as soon as possible.