zjunlp / EasyEdit

[ACL 2024] An Easy-to-use Knowledge Editing Framework for LLMs.
https://zjunlp.github.io/project/KnowEdit
MIT License
1.74k stars 210 forks source link

Unusually good locality scores for MEND? #259

Closed MichaelRipa closed 3 months ago

MichaelRipa commented 3 months ago

Hi,

I have been evaluating different model editing methods on a custom made benchmark, and so far, things have been seemingly consistent. However, when I run MEND, I am always getting locality scores of 0, indicating it is near perfect at avoiding modifying out of scope facts. Other edit techniques (e.g. ROME) do not have such drastically good scores on this dataset, thus I am worrying it is something incorrect in either how I trained the meta-learner or set up the edits.

Is there a particular reason why MEND specifically would have such good locality scores compared to other edit techniques or do you reckon that there is a fault in my setup? I tried downloading your pretrained MEND meta-learner weights and it had the same behaviour as my meta-learner I trained on CounterFact. Any thoughts or suggestions would be apprechiated.

I can provide more explicit details where needed.

Thanks!

pengzju commented 3 months ago
pengzju commented 3 months ago

If all your issues have been resolved, please help close this issue.