zjunlp / EasyEdit

[ACL 2024] An Easy-to-use Knowledge Editing Framework for LLMs.
https://zjunlp.github.io/project/KnowEdit
MIT License
1.74k stars 210 forks source link

Incorporating EMMET, a new model editing algorithm in EasyEdit #263

Closed akshat57 closed 1 month ago

akshat57 commented 3 months ago

Hi,

Recently we released a new model editing algorithm - EMMET or Equality-Constraint Mass Model Editing Algorithm for Transformers, which generalizes ROME to the batch setting. This essentially allows making batched edits using the ROME loss function.

The details of our work in present in our paper - https://arxiv.org/abs/2403.14236 And our github repo is this - https://github.com/scalable-model-editing/unified-model-editing

For the last month or so we've been working on stabilizing EMMET and finding the optimal hyperparameters. Now we can confidently say that it works atleast as well as MEMIT and in the paper we do present a few more ideas.

We would be grateful if our work can be incorporated in your repository and framework. We are happy to submit a PR if that makes things easier.

Thank, Akshat

XeeKee commented 3 months ago

Hello Akshat,

Thank you very much for your interest in EasyEdit. We will schedule support for it in the near future.

pengzju commented 3 months ago

Thx, feel free to submit PRs at any time. 👏

akshat57 commented 1 month ago

Hi,

We just submitted a PR for incorporating EMMET into EasyEdit. - https://github.com/zjunlp/EasyEdit/pull/334

Excited to finally have EMMET become part of the EasyEdit family.

Thanks, Akshat

zxlzr commented 1 month ago

Hi Akshat,

Thank you very much, we will check and merge it ASAP.

Best,

EasyEdit Team

XeeKee commented 1 month ago

Hello Akshat, thank you very much for your interest in easyedit. We have successfully merged your pull request into our repository. We appreciate it!