search

zk-org / zk-nvim

Neovim extension for zk
https://github.com/zk-org/zk
GNU General Public License v3.0
502 stars 40 forks source link

feat: link_note action on telescope picker #162

Closed celsobenedetti closed 4 months ago

celsobenedetti commented 6 months ago

Hello, I'd like to get some feedback on this feature. I'm creating this as PR rather than an issue since I already had some code for it from local experimenting.

Description

The idea is to add a new mapping for the Telescope picker for the ZkNotes command. This mapping (<C-l>) will create a link for the selected note under the cursor.

The behavior is equal to the ZkInsertLink command, but added as a utility for the ZkNotes commands.

Motivation

The ZkNotes command is the "main" command in my workflow. Thinking in terms of Zettlekasten, I often use it to check for any existing notes related to the context I'm currently writing about.

This is a quality of life feature for making the ZkNotes command even more useful.

This was inspired by obsidian.nvim, which provides this very feature through the ObsidianSearch command.

tjex commented 5 months ago

Hey, sorry for a slow reply! Thanks for the PR.

Sorry if I'm misunderstanding, but ZkInsertLink already functions like this. It brings up the note picker via telescope (same as ZKNotes). Selecting the note via Telescope then inserts the link at the cursor position. From my understanding that functionality is what you're trying to create with this PR?

github-actions[bot] commented 4 months ago

This pull request has been automatically marked as stale because it has not had recent activity.

tjex commented 4 months ago

closing for now. @ ping me back if you'd like to revive.