search

zk-org / zk-nvim

Neovim extension for zk
https://github.com/zk-org/zk
GNU General Public License v3.0
530 stars 42 forks source link

Add tags picker to Telescope extension. #54

Closed deforde closed 2 years ago

deforde commented 2 years ago

Added a function to facilitate loading the tags picker as a Telescope extension.

eric-hansen commented 2 years ago

Can there be documentation as to what the options are for this?

deforde commented 2 years ago

Good point - I added some text to the docs regarding the new functionality for the Telescope plugin. Similarly to the notes picker, I have not explicitly documented the available options in the Telescope plugin section itself, as this is already documented elsewhere. The available options are the same as those available to zk.list, as already reference in the docs. Although I did have issues getting the sort option to work - but that seemed to affect the extant :ZkNotes command as well - I will investigate this more closely later and provide an update.

eric-hansen commented 2 years ago

Sounds good, thanks!

I can't personally approve this but it gets a 👍🏻 from me. It's simple, necessary docs are there, etc...

If you find a resolution to the sort thing then it could be more beneficial as another PR since it impacts multiple commands. That way if there's an issue w/ those changes it doesn't hold this one up unnecessarily.