zk-org / zk

A plain text note-taking assistant
https://zk-org.github.io/zk/
GNU General Public License v3.0
1.69k stars 127 forks source link

Broken OSX release #189

Closed pwntester closed 2 years ago

pwntester commented 2 years ago

Hi,

I was using a self built zk instance (using go install --tags "icu json1 fts5 secure_delete") and that was working ok on OSX. I recently switched to nvim-lsp-installer which just grabs the OSX release and that executable throws the following error when run:

dyld[36613]: Library not loaded: /usr/local/opt/icu4c/lib/libicuuc.69.dylib
  Referenced from: /Users/pwntester/Downloads/zk
  Reason: tried: '/usr/local/opt/icu4c/lib/libicuuc.69.dylib' (no such file), '/usr/local/lib/libicuuc.69.dylib' (no such file), '/usr/lib/libicuuc.69.dylib' (no such file), '/usr/local/Cellar/icu4c/70.1/lib/libicuuc.69.dylib' (no such file), '/usr/local/lib/libicuuc.69.dylib' (no such file), '/usr/lib/libicuuc.69.dylib' (no such file)

I checked that the one distributed with homebrew also works ok and that /usr/local/Cellar/icu4c/70.1/lib/libicuuc.70.dylib is installed but the OSX github release is looking for version 69

Thanks

mickael-menu commented 2 years ago

Unfortunately the ICU lib is linked dynamically with zk, and linking statically is complicated (see https://github.com/mickael-menu/zk/discussions/76#discussioncomment-1419379).

This means that at some point the pre-built release binaries will get obsolete. Until we find a better solution, the preferred way to install zk is to build it yourself.

pwntester commented 2 years ago

Thanks for the reply @mickael-menu will future releases use latest ICU version?

mickael-menu commented 2 years ago

Yeah, I will upgrade my icu4c.

pwntester commented 2 years ago

Thanks!