zk-org / zk

A plain text note-taking assistant
https://zk-org.github.io/zk/
GNU General Public License v3.0
1.67k stars 124 forks source link

v0.14.1 homebrew release action failed #419

Closed tjex closed 4 months ago

tjex commented 4 months ago

Check if applicable

Describe the bug

Lodging this for now, to look at tomorrow. It's late in the evening 🌙

Action: https://github.com/zk-org/zk/actions/runs/9242929309/job/25426386503

How to reproduce?

na

zk configuration

na

Environment

No response

mickael-menu commented 4 months ago

I fixed the issue by creating a new token and modifying the repository secret HOMEBREW_GITHUB_TOKEN in Settings > Secrets and variables > Actions.

However the 0.14.1 was pushed manually on Homebrew by a contributor so the GitHub action still failed. That's fine as it's published. 👌

tjex commented 4 months ago

@mickael-menu Awesome. Was also looking into this and getting a bit confused about where that token needed to be set. However, I don't see any token or variable in the orgs settings.

Or is it that we should each generate a token for this github action?

The link takes me to my personal settings/tokens, rather than those for the orgs, which also confused the hell out of me from GitHub documentation.

https://github.com/settings/tokens vs https://github.com/organizations/zk-org/settings/secrets/actions

Screenshot 2024-05-27 at 18 13 40
mickael-menu commented 4 months ago

The secrets are per project, so it's in the Settings of the zk repo itself. But I guess it could work in the org secrets as well. I'm not sure we can provide a token from the organization itself, I used my personal account to generate the token. I didn't give any access to my personal info or private repo to the token, so that should be fine.

tjex commented 4 months ago

oh man. derp. of course 😅

Thanks :)