zk-org / zk

A plain text note-taking assistant
https://zk-org.github.io/zk/
GNU General Public License v3.0
1.64k stars 119 forks source link

Titles inside markdown links breaks LSP link completion #435

Open tjex opened 1 month ago

tjex commented 1 month ago

Check if applicable

Describe the bug

Related to #436

As was uncovered during discussion here: https://github.com/zk-org/zk-nvim/discussions/176#discussioncomment-10054556

The trigger pattern outlined here for regular markdown links is not triggering lsp completion properly.

We have previously looked at a similar issue with wikilink completion: zk-org/zk#397

How to reproduce?

  1. open a note
  2. type [link]((

LSP completion should trigger.

zk configuration

n/a. (although `link-format` in config will define how the link is subsequently inserted).

Environment

zk 0.14.1
system: Darwin 23.4.0 arm64
vandalt commented 1 month ago

I just wanted to mention I also get this behavior. More specifically:

I cannot reproduce the issue reported in #436, however (I'm on version 0.14.1, not the main branch).

tjex commented 3 weeks ago

Thanks for reporting. Your tests seem to be consistent with another user here: https://github.com/zk-org/zk-nvim/discussions/176#discussioncomment-10056002