search

zk-passport / openpassport

Generate privacy-preserving ID proofs
https://openpassport.app
311 stars 54 forks source link

Remove `signatureAlgorithm` and `pubKey` from `PassportData` type #182

Closed 0xturboblitz closed 2 days ago

0xturboblitz commented 2 weeks ago

We only want to keep dsc in PassportData. This is cleaner and we have nice functions to get the signature algorithm, hash function, hash length, etc from it.

Some scripts from common/scripts/passportData don't use DSCs but generate pubkeys manually. I added a mock ECDSA DSC generated from here and adapted sha256_ecdsa.ts as an example, but this should be done on other scripts. Once this is done, we can remove pubKey and signatureAlgorithm and always use getSignatureAlgorithm, getCircuitName, etc

Also, the ecdsa scripts in common/scripts/passportData still use node specific imports, so can't be added to the mock passport data generator in the app. The adaptation I made above works without node, so it will solve that too.

Iwueseiter commented 2 weeks ago

Hi @0xturboblitz can I work on this?

onlydustapp[bot] commented 2 weeks ago

Hey @Iwueseiter! Thanks for showing interest. We've created an application for you to contribute to Proof of Passport. Go check it out on OnlyDust!

0xturboblitz commented 2 weeks ago

Hi @0xturboblitz can I work on this?

This one is outside the scope of onlydust contributions