zk-passport / proof-of-passport

Proof of passport protocol using zk-SNARKs
https://proofofpassport.com
245 stars 32 forks source link

Implement MGF1 in circom #109

Closed 0xturboblitz closed 1 month ago

0xturboblitz commented 1 month ago

Implement MGF1 in circom, which will be a key part of the verification of RSA-PSS in circom, c.f. https://github.com/zk-passport/proof-of-passport/issues/38.

I would take inspiration from this.

Prabhat1308 commented 1 month ago

Hi. I have some experience in Circom and would like to take up this issue !

0xturboblitz commented 1 month ago

Cool please explain how you would tackle it

seshanthS commented 1 month ago

Hey @0xturboblitz, I would like to work on this issue.

I am a Solidity Dev, with some Circom experience. I have used it in few hobby projects before.

I found this spec (https://datatracker.ietf.org/doc/html/rfc8017#appendix-B.2.1) and will use it to tackle this issue

remicolin commented 1 month ago

Nice @Prabhat1308 @seshanthS, Can you take a look at the circuits repo and give a detailed plan on how you will tackle the issue ? If you want to work on circom circuits there is also other signatures algorithm to implement.

0xturboblitz commented 1 month ago

Closing, done in https://github.com/zk-passport/proof-of-passport/pull/115