search

zk-passport / proof-of-passport

Proof of passport protocol using zk-SNARKs
https://proofofpassport.com
245 stars 32 forks source link

feat: Implement MGF1 #115

Closed seshanthS closed 1 month ago

seshanthS commented 1 month ago

Implements #109

Tests: from proof-of-passport/circuits directory,

yarn ts-mocha test/Mgf1_sha256.test.ts

0xturboblitz commented 1 month ago

Hi @seshanthS

This is really cool!

I just added the mock passport data for rsassaPss here: https://github.com/zk-passport/proof-of-passport/blob/57ec1c3407ea1f66f348636a68e0d1c6cf914c65/common/src/utils/mockPassportData.ts#L105

If you want to continue working on this, you can now try doing the full implementation for rsassaPss using your mgf1

This would be super valuable, and also a nice way to test it as it's hard for us to know if your implementation follows the same one used in passports unless we test it with a compliant passport data like the one I just added.