zk-passport / proof-of-passport

Proof of passport protocol using zk-SNARKs
https://proofofpassport.com
260 stars 38 forks source link

Add support for DG11: optional attributes #65

Closed 0xturboblitz closed 1 month ago

0xturboblitz commented 5 months ago

Some countries including France fill the DG11 data group. See docs here.

It contains optional information like:

It would be great to support disclosure of those attributes in the circuit. This would include:

danielcdz commented 2 months ago

Hello @0xturboblitz I'm Daniel from Costa Rica! I have over 3 years of experience as a software engineer, I'm making my first contributions to OSS in web3 and blockchain projects, and I would like to help solve this issue! This is my 2nd ODHack!

0xturboblitz commented 2 months ago

Nice! dm me if you have any questions

danielcdz commented 2 months ago

@0xturboblitz sure! I think you forgot to assign me the issue btw

0xturboblitz commented 2 months ago

Hi, can you describe how you would tackle it before I assign it to you?

od-hunter commented 1 month ago

Can I be assigned this issue? I’ll update the circuits to include the attributes as instructed both during registration/disclosure. I’ll send a draft pr within 24 hours. Thank you

od-hunter commented 1 month ago

Thank you sir🙏🏾

0xturboblitz commented 1 month ago

Hi @od-hunter, any progress?

od-hunter commented 1 month ago

Good day sir @0xturboblitz , sorry I’m just getting back to you. I started solving this but I got sick and had to stop(seriously sick). I’m still sick as I type this, please kindly reassign this issue to someone else.🙏🏾 I’ll take up another task in the next OD hack if I feel better by then. I apologize once more please. Thank you for understanding.

0xturboblitz commented 1 month ago

Closing it right now as: