Try with more passports and improve reading

zk-passport / proof-of-passport

Proof of passport protocol using zk-SNARKs

https://proofofpassport.com

245 stars 32 forks source link

Try with more passports and improve reading #73

Open 0xturboblitz opened 4 months ago

0xturboblitz commented 4 months ago

The libraries we use for NFC reading work well in some cases but sometimes fail. One example of error I had recently with a passport on iOS is the following:

2024-03-04 21:39:27.2100 - Starting Password Authenticated Connection Establishment (PACE)
2024-03-04 21:39:27.2100 - Performing PACE with id-PACE-DH-GM-3DES-CBC-CBC
2024-03-04 21:39:38.2310 - PACE Failed - falling back to BAC
2024-03-04 21:39:38.2620 - Error reading tag: sw1 - 0x68, sw2 - 0x83
2024-03-04 21:39:38.2630 - reason: Last command of the chain expected

Trying with new passports and solving those bugs would really help. As with other issues, we will reward generously anyone helping on that, just DM us.

princeibs commented 4 months ago

Hi @0xturboblitz, this seems like an interesting fix. I would like to jump on it

0xturboblitz commented 4 months ago

please go ahead!

princeibs commented 3 months ago

Hi @0xturboblitz, I wanted to DM you concerning some assistance I need for this project, but i realised that your telegram handle is not in your OnlyDust profile. Please can you help me with other means I can reach out?

0xturboblitz commented 3 months ago

You can DM me at @FlorentTavernier on telegram

danielcdz commented 1 month ago

Hello! @0xturboblitz, I would like to help with this one!

Adecom16 commented 1 month ago

Hi @0xturboblitz i would love to work on this, can i ??

0xturboblitz commented 1 month ago

Please explain how you would tackle it first!

Adecom16 commented 1 month ago

Please explain how you would tackle it first!

I am Adeoluwa a smart contract developer. The possible solution to tackle this is:

Carefully audit the software implementation of the communication protocols (PACE, BAC) to ensure compliance with relevant specifications (e.g., ICAO Doc 9303).
Checking any software updates or patches that may address known issues or vulnerabilities.
Investigating potential interference from other electronic devices or environmental factors that may disrupt the NFC communication.
Try reading the passport in a different location or controlled environment.

danielcdz commented 1 month ago

Please explain how you would tackle it first!

I will tackle this by:

Testing with iOS devices and checking OS versions to discard issues caused by the device.
Focus on iOS issues related to NFC communication libraries, and check for non-braking changes and updates that may help fix the issues.
Test with passports in a controlled environment, the error can be caused by an uncontrolled environment and disruption from other devices.
Handle errors in a user-friendly way to send better logs for helping debugging in the future.

RJMadrigal commented 1 month ago

Hi! I would like to help with this issue.