search

zk1931 / jzab

ZooKeeper Atomic Broadcast in Java
http://zk1931.github.io/jzab/master/
Apache License 2.0
54 stars 23 forks source link

Bump protobuf-java dep to 2.6.1 #171

Closed rgs1 closed 9 years ago

rgs1 commented 10 years ago

Signed-off-by: Raul Gutierrez S rgs@twitter.com

ghost commented 10 years ago

Thanks for the patch @rgs1

We do apt-get install to install protobuf-compiler, and I'm guessing it installs version 2.4.*. If we are bumping protobuf version to 2.5, we also need to make sure protobuf-compiler version is 2.5.

https://github.com/zk1931/jzab/blob/66524470d147514da14579c934ab49adda1155e1/.travis.yml#L16

ghost commented 10 years ago

Also please update the README.md file.

ghost commented 10 years ago

I googled around a bit, it looks like people manually install protobuf when they need 2.5:

https://github.com/peter-edge/ruby-protocol-buffers-require/blob/master/.travis.yml

ghost commented 10 years ago

the latest release is 2.6.1. let's bump it up to the latest version while we are at it.

https://github.com/google/protobuf/releases

ghost commented 9 years ago

fixed in https://github.com/zk1931/jzab/pull/170